refactor: update blas/ext/base/dapxsumpw to follow current project conventions
#1996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
the
BLAS
ShivamAhir
changed the title
ShivamAhir
changed the title
Planeshifter
added
Needs Review
Planeshifter
changed the title
blas/ext/base/dapxsumpw to follow current project conventions
Planeshifter
requested changes
Mar 23, 2024
Planeshifter
added
Needs Changes
|
@Planeshifter I think I understood what you wanted me to correct, and I have made the necessary adjustments, including adding the missing include and updating the dependencies in the |
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Planeshifter
approved these changes
Mar 24, 2024
There was a problem hiding this comment.
Thanks for the changes!
Had to fix the indentation in the manifest file (make sure you have an .editorconfig extension for your code editor installed, then the files should be auto-formatted on save), but otherwise looks all good to me now. Will merge shortly after CI has passed.
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves # .
Description
This pull request:
Related Issues
This pull request:
blas/ext/base/dapxsumpwto follow current project conventions #1469Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers